Constified numerous function parameters.

As was pointed out by the cppcheck[0] static code analysis utility we
can mark numerous function parameters as 'const'. This acts as a hint to
the compiler a

Constified numerous function parameters.

As was pointed out by the cppcheck[0] static code analysis utility we
can mark numerous function parameters as 'const'. This acts as a hint to
the compiler about our intentions and the compiler will tell us when we
deviate from them.

[0]: https://cppcheck.sourceforge.io/

show more ...

Introduced SCM_CREDENTIALS / SCM_CREDS in the socket control msgs.

Deduplicating code for closing fds in nxt_port_send_msg_t.

Fixing memory and descriptor leakage in case of port send failure.

In rare cases, when the destination process had finished running but no
notification of this was received yet, send could fail with

Fixing memory and descriptor leakage in case of port send failure.

In rare cases, when the destination process had finished running but no
notification of this was received yet, send could fail with an error, and the
send message structure with file descriptors could leak.

The leakage was periodically reproduced by respawn tests on FreeBSD 12.

show more ...

Fixing shm buffer leakage when sending over the port queue.

When the shm buffer is sent over the port queue, it needs to be completed
because it's sent over the port socket.

Fixing issues found by static analyzer.

Style fixes for 2 file descriptors transfer over port.

Two consecutive fd and fd2 fields replaced with array.

Introducing application and port shared memory queues.

The goal is to minimize the number of syscalls needed to deliver a message.

Port message extended to transfer 2 file descriptors.

Closing unsent file descriptors from port queue.

After a process exits, all ports linked to it from other processes
should be closed. All unsent file descriptors in port queue, marked as
"close aft

Closing unsent file descriptors from port queue.

After a process exits, all ports linked to it from other processes
should be closed. All unsent file descriptors in port queue, marked as
"close after send", should be closed to avoid resource leakage.

show more ...

Introduced chained buffer completion handlers.

Fixing multi-thread port write racing conditions.

Fixing allocation alignment for port fragments.

All allocated blocks for lvlhash required to be aligned because lower
address bits used for various extra information. Using unaligned blocks
may cau

Fixing allocation alignment for port fragments.

All allocated blocks for lvlhash required to be aligned because lower
address bits used for various extra information. Using unaligned blocks
may cause invalid memory aceess.

This was issue found on buildbot running large configuration tests.

show more ...

Turning off port read event state after main process fork.

Master port stores two file descriptors and works as a read port on the master
process side. After a fork, the port switches into write mo

Turning off port read event state after main process fork.

Master port stores two file descriptors and works as a read port on the master
process side. After a fork, the port switches into write mode and the read
socket closes, but the same event structure is used for the write socket.
However, the inherited structure remained in read state, telling the epoll
engine to use MOD operation instead of ADD. The patch resets read event
state, so the engine may write using proper ADD operation.

show more ...

Improving port message fragment recognition.

This is required to assemble fragmented messages correctly. Stream
identifier is unique only for messages generated within a process, but
the (stream, p

Improving port message fragment recognition.

This is required to assemble fragmented messages correctly. Stream
identifier is unique only for messages generated within a process, but
the (stream, pid) pair should be enough to avoid collisions. Adding
reply_port seems redundant because it's enough to add stream to a pid.

This closes #199 issue on GitHub.
Thanks to 洪志道 (Hong Zhi Dao).

show more ...

Fixing EAGAIN processing for port message send.

Sending large plain (exceeding port's max_size, not in shared memory) messages
causes message fragmentation. First message fragment is sent successfu

Fixing EAGAIN processing for port message send.

Sending large plain (exceeding port's max_size, not in shared memory) messages
causes message fragmentation. First message fragment is sent successfully,
but the next fragment may fail with the EAGAIN error. In this case, the
message has to be pushed back to queue head for additional processing.

Related to #167 issue on GitHub.

show more ...

Including port message header into message size limit.

Before this fix, large plain message (i.e. configuration) send may fail
with the 'Message too big' error, because internal fragmentation
implem

Including port message header into message size limit.

Before this fix, large plain message (i.e. configuration) send may fail
with the 'Message too big' error, because internal fragmentation
implementation does not account for 16 byte message header.

This closes #167 issue on GitHub.

show more ...

Preserving message 'share' field when pushing to queue.

As far as I understand, this field is important to control the number of
buffers send in a single write attempt. Furthermore, having uninitia

Preserving message 'share' field when pushing to queue.

As far as I understand, this field is important to control the number of
buffers send in a single write attempt. Furthermore, having uninitialized
field is always bad.

This closes #204 issue on GitHub.
Thanks to 洪志道 (Hong Zhi Dao).

show more ...

Reusing fragmented message buffers.

Fragmented message non-mmap buffer chain not freed nor reused before
this fix.

This closes #206 on GitHub.
Thanks to 洪志道 (Hong Zhi Dao).

Style.

nxt_port_buf_completion() and nxt_sendbuf_completion().

nxt_sendbuf_completion() has been renamed to nxt_port_buf_completion()
and moved to src/nxt_port_socket.c. nxt_sendbuf_completion0() has been

nxt_port_buf_completion() and nxt_sendbuf_completion().

nxt_sendbuf_completion() has been renamed to nxt_port_buf_completion()
and moved to src/nxt_port_socket.c. nxt_sendbuf_completion0() has been
renamed to nxt_sendbuf_completion().

show more ...

Reduced number of critical log levels.

Removed unwanted assertions.

Style fixes.

Changed nxt_mp_retain() and nxt_mp_release() interfaces.